parse_test.go 7.4 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167
  1. package ftp
  2. import (
  3. "strings"
  4. "testing"
  5. "time"
  6. )
  7. var (
  8. // now is the current time for all tests
  9. now = newTime(2017, time.March, 10, 23, 00)
  10. thisYear, _, _ = now.Date()
  11. previousYear = thisYear - 1
  12. )
  13. type line struct {
  14. line string
  15. name string
  16. size uint64
  17. entryType EntryType
  18. time time.Time
  19. }
  20. type unsupportedLine struct {
  21. line string
  22. err string
  23. }
  24. var listTests = []line{
  25. // UNIX ls -l style
  26. {"drwxr-xr-x 3 110 1002 3 Dec 02 2009 pub", "pub", 0, EntryTypeFolder, newTime(2009, time.December, 2)},
  27. {"drwxr-xr-x 3 110 1002 3 Dec 02 2009 p u b", "p u b", 0, EntryTypeFolder, newTime(2009, time.December, 2)},
  28. {"-rw-r--r-- 1 marketwired marketwired 12016 Mar 16 2016 2016031611G087802-001.newsml", "2016031611G087802-001.newsml", 12016, EntryTypeFile, newTime(2016, time.March, 16)},
  29. {"-rwxr-xr-x 3 110 1002 1234567 Dec 02 2009 fileName", "fileName", 1234567, EntryTypeFile, newTime(2009, time.December, 2)},
  30. {"lrwxrwxrwx 1 root other 7 Jan 25 00:17 bin -> usr/bin", "bin -> usr/bin", 0, EntryTypeLink, newTime(thisYear, time.January, 25, 0, 17)},
  31. // Another ls style
  32. {"drwxr-xr-x folder 0 Aug 15 05:49 !!!-Tipp des Haus!", "!!!-Tipp des Haus!", 0, EntryTypeFolder, newTime(thisYear, time.August, 15, 5, 49)},
  33. {"drwxrwxrwx folder 0 Aug 11 20:32 P0RN", "P0RN", 0, EntryTypeFolder, newTime(thisYear, time.August, 11, 20, 32)},
  34. {"-rw-r--r-- 0 18446744073709551615 18446744073709551615 Nov 16 2006 VIDEO_TS.VOB", "VIDEO_TS.VOB", 18446744073709551615, EntryTypeFile, newTime(2006, time.November, 16)},
  35. // Microsoft's FTP servers for Windows
  36. {"---------- 1 owner group 1803128 Jul 10 10:18 ls-lR.Z", "ls-lR.Z", 1803128, EntryTypeFile, newTime(thisYear, time.July, 10, 10, 18)},
  37. {"d--------- 1 owner group 0 Nov 9 19:45 Softlib", "Softlib", 0, EntryTypeFolder, newTime(previousYear, time.November, 9, 19, 45)},
  38. // WFTPD for MSDOS
  39. {"-rwxrwxrwx 1 noone nogroup 322 Aug 19 1996 message.ftp", "message.ftp", 322, EntryTypeFile, newTime(1996, time.August, 19)},
  40. // RFC3659 format: https://tools.ietf.org/html/rfc3659#section-7
  41. {"modify=20150813224845;perm=fle;type=cdir;unique=119FBB87U4;UNIX.group=0;UNIX.mode=0755;UNIX.owner=0; .", ".", 0, EntryTypeFolder, newTime(2015, time.August, 13, 22, 48, 45)},
  42. {"modify=20150813224845;perm=fle;type=pdir;unique=119FBB87U4;UNIX.group=0;UNIX.mode=0755;UNIX.owner=0; ..", "..", 0, EntryTypeFolder, newTime(2015, time.August, 13, 22, 48, 45)},
  43. {"modify=20150806235817;perm=fle;type=dir;unique=1B20F360U4;UNIX.group=0;UNIX.mode=0755;UNIX.owner=0; movies", "movies", 0, EntryTypeFolder, newTime(2015, time.August, 6, 23, 58, 17)},
  44. {"modify=20150814172949;perm=flcdmpe;type=dir;unique=85A0C168U4;UNIX.group=0;UNIX.mode=0777;UNIX.owner=0; _upload", "_upload", 0, EntryTypeFolder, newTime(2015, time.August, 14, 17, 29, 49)},
  45. {"modify=20150813175250;perm=adfr;size=951;type=file;unique=119FBB87UE;UNIX.group=0;UNIX.mode=0644;UNIX.owner=0; welcome.msg", "welcome.msg", 951, EntryTypeFile, newTime(2015, time.August, 13, 17, 52, 50)},
  46. // Format and types have first letter UpperCase
  47. {"Modify=20150813175250;Perm=adfr;Size=951;Type=file;Unique=119FBB87UE;UNIX.group=0;UNIX.mode=0644;UNIX.owner=0; welcome.msg", "welcome.msg", 951, EntryTypeFile, newTime(2015, time.August, 13, 17, 52, 50)},
  48. // DOS DIR command output
  49. {"08-07-15 07:50PM 718 Post_PRR_20150901_1166_265118_13049.dat", "Post_PRR_20150901_1166_265118_13049.dat", 718, EntryTypeFile, newTime(2015, time.August, 7, 19, 50)},
  50. {"08-10-15 02:04PM <DIR> Billing", "Billing", 0, EntryTypeFolder, newTime(2015, time.August, 10, 14, 4)},
  51. // dir and file names that contain multiple spaces
  52. {"drwxr-xr-x 3 110 1002 3 Dec 02 2009 spaces dir name", "spaces dir name", 0, EntryTypeFolder, newTime(2009, time.December, 2)},
  53. {"-rwxr-xr-x 3 110 1002 1234567 Dec 02 2009 file name", "file name", 1234567, EntryTypeFile, newTime(2009, time.December, 2)},
  54. {"-rwxr-xr-x 3 110 1002 1234567 Dec 02 2009 foo bar ", " foo bar ", 1234567, EntryTypeFile, newTime(2009, time.December, 2)},
  55. // Odd link count from hostedftp.com
  56. {"-r-------- 0 user group 65222236 Feb 24 00:39 RegularFile", "RegularFile", 65222236, EntryTypeFile, newTime(thisYear, time.February, 24, 0, 39)},
  57. }
  58. // Not supported, we expect a specific error message
  59. var listTestsFail = []unsupportedLine{
  60. {"d [R----F--] supervisor 512 Jan 16 18:53 login", "Unsupported LIST line"},
  61. {"- [R----F--] rhesus 214059 Oct 20 15:27 cx.exe", "Unsupported LIST line"},
  62. {"drwxr-xr-x 3 110 1002 3 Dec 02 209 pub", "Invalid year format in time string"},
  63. {"modify=20150806235817;invalid;UNIX.owner=0; movies", "Unsupported LIST line"},
  64. {"Zrwxrwxrwx 1 root other 7 Jan 25 00:17 bin -> usr/bin", "Unknown entry type"},
  65. {"total 1", "Unsupported LIST line"},
  66. {"000000000x ", "Unsupported LIST line"}, // see https://github.com/jlaffaye/ftp/issues/97
  67. {"", "Unsupported LIST line"},
  68. }
  69. func TestParseValidListLine(t *testing.T) {
  70. for _, lt := range listTests {
  71. entry, err := parseListLine(lt.line, now, time.UTC)
  72. if err != nil {
  73. t.Errorf("parseListLine(%v) returned err = %v", lt.line, err)
  74. continue
  75. }
  76. if entry.Name != lt.name {
  77. t.Errorf("parseListLine(%v).Name = '%v', want '%v'", lt.line, entry.Name, lt.name)
  78. }
  79. if entry.Type != lt.entryType {
  80. t.Errorf("parseListLine(%v).EntryType = %v, want %v", lt.line, entry.Type, lt.entryType)
  81. }
  82. if entry.Size != lt.size {
  83. t.Errorf("parseListLine(%v).Size = %v, want %v", lt.line, entry.Size, lt.size)
  84. }
  85. if !entry.Time.Equal(lt.time) {
  86. t.Errorf("parseListLine(%v).Time = %v, want %v", lt.line, entry.Time, lt.time)
  87. }
  88. }
  89. }
  90. func TestParseUnsupportedListLine(t *testing.T) {
  91. for _, lt := range listTestsFail {
  92. _, err := parseListLine(lt.line, now, time.UTC)
  93. if err == nil {
  94. t.Errorf("parseListLine(%v) expected to fail", lt.line)
  95. }
  96. if err.Error() != lt.err {
  97. t.Errorf("parseListLine(%v) expected to fail with error: '%s'; was: '%s'", lt.line, lt.err, err.Error())
  98. }
  99. }
  100. }
  101. func TestSettime(t *testing.T) {
  102. tests := []struct {
  103. line string
  104. expected time.Time
  105. }{
  106. // this year, in the past
  107. {"Feb 10 23:00", newTime(thisYear, time.February, 10, 23)},
  108. // this year, less than six months in the future
  109. {"Sep 10 22:59", newTime(thisYear, time.September, 10, 22, 59)},
  110. // previous year, otherwise it would be more than 6 months in the future
  111. {"Sep 10 23:00", newTime(previousYear, time.September, 10, 23)},
  112. // far in the future
  113. {"Jan 23 2019", newTime(2019, time.January, 23)},
  114. }
  115. for _, test := range tests {
  116. entry := &Entry{}
  117. entry.setTime(strings.Fields(test.line), now, time.UTC)
  118. if !entry.Time.Equal(test.expected) {
  119. t.Errorf("setTime(%v).Time = %v, want %v", test.line, entry.Time, test.expected)
  120. }
  121. }
  122. }
  123. // newTime builds a UTC time from the given year, month, day, hour and minute
  124. func newTime(year int, month time.Month, day int, hourMinSec ...int) time.Time {
  125. var hour, min, sec int
  126. switch len(hourMinSec) {
  127. case 0:
  128. // nothing
  129. case 3:
  130. sec = hourMinSec[2]
  131. fallthrough
  132. case 2:
  133. min = hourMinSec[1]
  134. fallthrough
  135. case 1:
  136. hour = hourMinSec[0]
  137. default:
  138. panic("too many arguments")
  139. }
  140. return time.Date(year, month, day, hour, min, sec, 0, time.UTC)
  141. }